SpotifyControls equivalent for other players/apps

Vencord / plugin-requests

Vencord plugin requests. Open the link below to create a request

https://github.com/Vencord/plugin-requests/issues/new?template=request.yml

27 stars 4 forks source link

SpotifyControls equivalent for other players/apps #198

Open goldentg opened 3 months ago

goldentg commented 3 months ago

Plugin Description

A plugin similar to the spotify controls, although it allows you to control rhythmbox/youtube music/etc etc rather than spotify

Existing Plugin for other mod

https://github.com/Vendicated/Vencord/tree/main/src/plugins/spotifyControls

Request Agreement

[X] I read the above and made sure my plugin is possible and allowed
[X] I checked the existing plugins and made sure my plugin doesn't already exist
[X] I searched the existing issues and made sure a similar request doesn't already exist

D3SOX commented 3 months ago

I think it would make much more sense to support the system media API (MPRIS2?) instead of doing a specific Rhythmbox integration as it works with many players (including Spotify lol with which I can confirm it provides all necessary data to make it function exactly like the SpotifyControls plugin)

Sqaaakoi commented 3 months ago

I think it would make much more sense to support the system media API (MPRIS2?) instead of doing a specific Rhythmbox integration as it works with many players (including Spotify lol with which I can confirm it provides all necessary data to make it function exactly like the SpotifyControls plugin)

vee said "you cannot do dbus" to me when I brought up the idea of using dbus to control discord. maybe this needs to be a shared API to do native dbus stuff in vencord, as some kind of native or binding is required to do that

D3SOX commented 3 months ago

@Sqaaakoi Vencord also runs git commands so it could theoretically also run something like qdbus and why is it impossible to do it in native (or with some kind of dbus library idk)?

Sqaaakoi commented 3 months ago

@Sqaaakoi Vencord also runs git commands so it could theoretically also run something like qdbus and why is it impossible to do it in native (or with some kind of dbus library idk)?

it's not technically "impossible", vee probably just meant really inconvenient also, can qdbus even do the listening required for mpris?

Vendicated commented 3 months ago

i never said "you cannot do dbus". i said you cannot use a native library, so you'd have to use a cli, such as playerctl

Sqaaakoi commented 3 months ago

i never said "you cannot do dbus". i said you cannot use a native library, so you'd have to use a cli, such as playerctl

you said "you cannot do dbus" to someting completely unrelated

yes playerctl is probably the best way to do this specific case

nin0-dev commented 3 months ago

if this is ever added it would need to be windows, mac, linux, ~~and vendroid~~ compatible

not sure if playerctl is available on windows / mac

D3SOX commented 3 months ago

MPRIS2 is only for Linux afaik. We would need different backend implementations so I this should probably be written dynamically. Maybe there is already a library that works and does it.. We could then even replace the SpotifyControls plugin and add Spotify as a backend for the new plugin. As for Vendroid support, I don't think that's something we look out for.