Vencord / plugin-requests

Vencord plugin requests. Open the link below to create a request
https://github.com/Vencord/plugin-requests/issues/new?template=request.yml
29 stars 4 forks source link

Remember messages if you lose access to a channel #875

Open zumbiepig opened 2 months ago

zumbiepig commented 2 months ago

Plugin Description

I dont know if this counts as Plugins that are not possible: Reading private channels, but if you lose access to a channel while you were in that channel, you can still read the messages in that channel that were sent prior to you losing access. However, if you click another channel, then you won't be able to read the channel you lost access to. Vencord could remember the messages you saw, and let you see them again.

Could be part of the ShowHiddenChannels mod.

Existing Plugin for other mod

No response

Request Agreement

Sqaaakoi commented 2 months ago

This is possible, but potentially not appropriate for Vencord for a few reasons

  1. Requests for MessageLogger to save logs is possible and has been developed, but Vencord does not want to make such functionality available for many reasons (such as disk space and ease of long-term stalking)
  2. The Discord client can sometimes clear a channel from the cache. This can be easily noticed if you use slash commands that return ephemeral output. There is no workaround for this in Vencord, so this is also noticeable if you use MessageLogger
  3. Depending on implementation, this would require recent messages from every channel to be cached on the client, which would be bad for memory usage

Conclusion: Possible, but don't expect this, and if it is added, expect Vencord's implementation to only keep the data as long as Discord normally would keep it cached

zumbiepig commented 2 months ago

Maybe Vencord can store text-only data (no gifs or images, but emojis can be stored as :emoji:) in memory for up to 1 hour or until Discord closes.

ImLvna commented 2 months ago

storing that on disk is borderline stalkerish and has been denied

Sqaaakoi commented 2 months ago

implementing this could be as simple as just pretending we have permission to read the channel if there are messages cached

zumbiepig commented 2 months ago

And only store what is said while you are focused on the channel. Otherwise have a thing saying "Not focused between time and time"

zumbiepig commented 2 months ago

implementing this could be as simple as just pretending we have permission to read the channel if there are messages cached

I think thats a good compromise for not stalking.