Vencord / plugin-requests

Vencord plugin requests. Open the link below to create a request
https://github.com/Vencord/plugin-requests/issues/new?template=request.yml
29 stars 2 forks source link

Youtube AD block #974

Closed Sazoji closed 3 months ago

Sazoji commented 3 months ago

Plugin Description

Problem:

Very recently, youtube has begun to implement ads within discord embeds

Solutions:

I do have concerns with editing embeds as the client is then interacting potentially with URL grabbers without interacting with the embed, and the URL redirect could be obfuscated with blue text, so you'd never know that a 3rd party grabbed your ip after clicking a play button that embeds an ad-free version of youtube. The top 2 solutions are ideal for security IMO, but something similar to or built within FixYoutubeEmbeds would be what I expect most people would think it'd work.

Existing Plugin for other mod

OpenInApp exists, but to translate URLs for apps, not executing a command with custom args to launch something like MPV or ytdlp/ffmpeg FixYoutubeEmbeds functions similarly but not for ads in the embed WatchTogetherAdblock does the expected for watch together sessions

Request Agreement

prototype464 commented 3 months ago

Yes please. Absolutely. I've blocked ads on everything everywhere else I can. Screw Alphabet, Google, and YouTube. Screw them. This is stupid. Ads are awful. Sick of them. They are so damn loud and obnoxious.

Sazoji commented 3 months ago

I've worked around this by setting up the discord webapp in firefox with the tampermonkey extension, UBO also works and blocks ads on the embeds as intended. Theme support seems to work despite the warning. If you open up edge (with extensions enabled for webapps) you could make your own standalone webapp with Vencord and UBO/SponsorBlock/etc in a few clicks. Would save some ram too if you keep your microsoft default browser open (ew)

I'm off the main vencord server for now, so any feedback in this thread for suggestions on the best execution for removing ads from youtube embeds would be appreciated here!

TheOneWhoBuilds1 commented 3 months ago

Literrally had the same idea not long ago

nvhhr commented 3 months ago

This was just added today with version 1.9.7 https://github.com/Vendicated/Vencord/commit/0f8d21a8461b716d9aac9a5f58c18c9a4d64dd27

https://vencord.dev/plugins/YoutubeAdblock