search

Vendicated / Vencord

The cutest Discord client mod
https://vencord.dev
GNU General Public License v3.0
7.97k stars 1.12k forks source link

fix(ShowMeYourName) - proper case insensitive name comparison #2633

Closed Jono997 closed 1 week ago

Jono997 commented 3 weeks ago

There seems to be a bug where when a user's name has capital letters, this plugin always acts as if the username and nickname are different. This is my attempt to fix it.

RealityWinner commented 3 weeks ago

@Bloofield This broke due to your previous PR https://github.com/Vendicated/Vencord/pull/2630

Bloofield commented 3 weeks ago

@Bloofield This broke due to your previous PR #2630

Interesting. I assumed usernames would always be lowercase which is why I didn't add the lowercase conversion for usernames

Jono997 commented 3 weeks ago

So will this be merged or the other PR reverted?

Bloofield commented 3 weeks ago

@Jono997 This one should be merged. There needs to be a lowercase conversion to prevent duplicate usernames from showing up.

The thought behind the original PR was to prevent nicknames with capitalisation in them from being shown.

hideki2k02 commented 3 weeks ago

Up on this. Just waiting for this to get merged so I can make a few changes too

RealityWinner commented 3 weeks ago

@Vendicated can you please merge this and fix the broken plugin since https://github.com/Vendicated/Vencord/pull/2630 you merged the other day

Jono997 commented 3 weeks ago

@Vendicated Sorry for bugging you again, but can you please take a look at this?

Jono997 commented 2 weeks ago

Well, uh, that's one way to solve the problem.

maddie480 commented 2 weeks ago

Uh yeah, that's just a fork I made for myself for developing a plugin :sweat_smile: And given that I rebase the branch to keep my Vencord up-to-date, I'm spamming quite a bit here, I'm going to remove the mention

(also, I didn't mean to mock anyone with that trollface message there, that's why I amended the commit 1 minute later but well, it was too late)