Vendicated / Vencord

The cutest Discord client mod
https://vencord.dev
GNU General Public License v3.0
7.97k stars 1.12k forks source link

[Bug] ShowAllRoles causing clipping issues with Profiles that contains lots of roles! #2649

Closed ColynOrg closed 1 week ago

ColynOrg commented 3 weeks ago

Discord Account

No response

What happens when the bug or crash occurs?

when clicking a persons profile whom has lots of roles, the profile just gets stuck, you're not able to scroll up or down, leaving to have to use the right click menu if you want to try and add them as a friend and such. image

What is the expected behaviour?

I expect ShowAllRoles to handle this kind of problem with profiles that have plenty of roles, possibly some sort of scrolling feature perhaps.

How do you recreate this bug or crash?

  1. click on a persons profile whom may have a lot of roles.
  2. you'll discover that you can not do anything besides receiving a clipped profile, not being able to scroll or add them as a friend etc unless you use the right click menu.

Errors

Replace this text with your crash-log.

Request Agreement

iamqw3rty commented 3 weeks ago

having the same issue image

Luna-devv commented 3 weeks ago

Very funny - 1. why would you have that many roles - 2. I haven’t really tested it with that many roles to be fair and I have large screens - 3. question is how to solve this, scroll(?), limit the amount of roles (?) like 50(?), add a setting to set the amount(?)

Luna-devv commented 3 weeks ago

Adding this to your quick css makes the roles scrollable if the roles list is longer than the height of discord

[class*="userPopoutInner_"] >
[class*="body_"] {
    overflow-y: scroll;
}

[class*="userPopoutInner_"] >
[class*="body_"]::-webkit-scrollbar {
    display: none;
}

https://github.com/Vendicated/Vencord/assets/71079641/98d0d937-aa46-4911-b63f-0a1a04958901

PLEASE NOTE

The ShowAllRoles plugin was made for the new simplified profiles, it is not intended to work with the old profile pop outs

ColynOrg commented 3 weeks ago

Very funny - 1. why would you have that many roles - 2. I haven’t really tested it with that many roles to be fair and I have large screens - 3. question is how to solve this, scroll(?), limit the amount of roles (?) like 50(?), add a setting to set the amount(?)

i was thinking scroll but like the same way as if you were hovering over a long status bubble within a profile and it just shows the rest of the content, once unhovered you can have it scroll all the way back up or something. here's an example of how i copied the same behavior but with my about me. example

ColynOrg commented 2 weeks ago

this issue is fixed so far for canary build as they also add a scroller to the popout. just awaiting for the release on stable build.