Vendicated / Vencord

The cutest Discord client mod
https://vencord.dev
GNU General Public License v3.0
7.97k stars 1.12k forks source link

ShowHiddenThings: Show guild member list page (settings, sidebar) with/without community mode #2652

Open Sqaaakoi opened 3 weeks ago

Sqaaakoi commented 3 weeks ago

Before I explain what this does, here's what it doesn't do (for people who stumble upon this PR)

This does not and cannot bypass permissions for that menu (I have tried before)

This adds a few more options to ShowHiddenThings, related to the Members page, visible as a channel linked in the sidebar, and in the settings. Unfortunately, Discord adds arbitrary restrictions based upon if your server is a "community" or not to decide where the page is visible.

Options

Show Members Page In Settings

In non community servers, this option will force the members page to show in settings if the Show Members in Channel List is on Example of before: Message saying "The members page has been moved to the server channel list. [Go there]" In community servers, without this option enabled the button in the settings sidebar is replaced with a button which redirects you to the channel providing the members page. Enabling this option will remove the redirect and restores viewing the members page in the settings directly.

Show Members Page In Sidebar

Shows the members page button in the sidebar (and re-enables the page outside of settings, because Discord for some reason has a check to send you to the settings where the page is shown) in non-community servers without the force enable toggle enabled. Example of sidebar, with the members page "channel" circled

Concerns about the plugin description

Considering many people often ask for a permission bypass for this feature (when it isn't possible, which I already mentioned), I feel the description of the plugin needs to be changed to not mislead users into thinking such a permission bypass is included in the plugin. I don't know specifically how the description should be rewritten, and as such that is why I have left this note here.