search

Vendicated / Vencord

The cutest Discord client mod
https://vencord.dev
GNU General Public License v3.0
7.97k stars 1.12k forks source link

feat(UserVoiceShow): update for simplified profiles #2665

Open vishnyanetchereshnya opened 3 weeks ago

vishnyanetchereshnya commented 3 weeks ago

patches update for simplified profiles Discord_0MPZMH7xoG Discord_lBw7b2Ee5e

vishnyanetchereshnya commented 2 weeks ago

you shouldn't override old patches, in case

  • by some modern day miracle some people manage to turn off simplified profiles
  • bots still use old profiles

oh yea, u right

vishnyanetchereshnya commented 2 weeks ago

~btw I'm not sure to where place voice status in user popup. originally this component located between send message section and roles section. in simplified profile already exists some "voice status"(activity), I just override it by section from this plugin and now this one located ABOVE roles section. would it be better to move it as in original plugin (below roles)?~

UPD: just remembered that activity shows not only voice but also other information 🥴. removed the override of this section and moved the voice channel section under the roles section

Vendicated commented 1 week ago

could you show a screenshot please?

vishnyanetchereshnya commented 1 week ago

could you show a screenshot please?

yup, added into main pr message

Vendicated commented 1 week ago

it takes up too much space. the header should probably be removed in the small profile and replaced with a vc icon

as for the large profile, the header style is inconsistent with discord

vishnyanetchereshnya commented 1 week ago

it takes up too much space. the header should probably be removed in the small profile and replaced with a vc icon

as for the large profile, the header style is inconsistent with discord

popout: will replace header by vc icon on left side of button modal: will change text style of header

btw as nino-dev said bots still uses old profiles. does plugin have to have patches for them?

Sqaaakoi commented 1 week ago

as for the large profile, the header style is inconsistent with discord

I know I've been talking about this a lot (and even opened a technically redundant PR related to it #2690 ), but you can use the Section component I found (see the previously linked PR and #2635 for examples)

btw as nino-dev said bots still uses old profiles. does plugin have to have patches for them?

enable the experiment for simplified bot profiles. i would ideally make sure it works there

also, not entirely related to this patch, a user can be in multiple voice channels at the same time, as long as they are in different servers. this might be more common with bots so maybe check if that is considered