search

Vendicated / Vencord

The cutest Discord client mod
https://vencord.dev
GNU General Public License v3.0
7.97k stars 1.12k forks source link

Fix: ViewIcons blocking opening profile in DMs #2666

Closed Obsidianninja11 closed 1 week ago

Obsidianninja11 commented 2 weeks ago

The ViewIcons plugin was blocking users from opening the bigger profile by clicking the pfp in the right side panel in dms

Image of where I'm talking about ![image](https://github.com/Vendicated/Vencord/assets/108832807/4c9bdd69-bbb8-4c41-a563-713b0f2febdf)

~~Before fix: Clicking on this pfp would open the pfp as an image preview After fix: Clicking on this pfp opens the big profile view as expected~~

Fixed in https://github.com/Vendicated/Vencord/commit/92ae62602b3364f30bb69a7d0155bb2a1c0753d3

Scyye commented 2 weeks ago

Looking at it, this doesnt seem like a fix, more of just a.. feature removal..

i'd add a setting for it, and add a predicate to those 2 patches.

Obsidianninja11 commented 2 weeks ago

Looking at it, this doesnt seem like a fix, more of just a.. feature removal..

i'd add a setting for it, and add a predicate to those 2 patches.

This is a bug. It used to not block opening from the profile menu from clicking this pfp. The feature is meant to make the normally non-clickable pfps clickable to view the avatar (and also add it to the right click menu)

(also there's already 4 ways (5 if you want to scroll to the very top of the dm) to view the avatar from dms) (and you can view the avatar from the large profile menu that opens after clicking the pfp)