search

Vendicated / Vencord

The cutest Discord client mod
https://vencord.dev
GNU General Public License v3.0
7.97k stars 1.12k forks source link

New plugin: AutoThemeSwitcher #2679

Closed maddie480 closed 1 week ago

maddie480 commented 2 weeks ago

So, here is a plugin I made for myself a bit ago, for switching between a "light" and a "dark" theme based on the time of day:

attachment

This matches up with a plugin request that was made 2 weeks ago (https://github.com/Vencord/plugin-requests/issues/772), but still, feel free to tell me if this would be better as a third-party plugin :sweat_smile:

sadan4 commented 2 weeks ago

this plugin seems better done via the native discord feature of syncing with your computer theme. image

maddie480 commented 1 week ago

this plugin seems better done via the native discord feature of syncing with your computer theme. image

The plugin lets you select other themes besides Light and Dark, unsure how niche this is though 🤔

And I never got the system theme option to work on my Linux Mint 😅 no clue why

maddie480 commented 1 week ago

It's the second time I'm seeing comments about the new option type (including core-development on the Discord), should I switch to a comma-separated list? I just noticed that it's what MessageLogger uses 🤔

maddie480 commented 1 week ago

Turns out it's probably not too niche, but too confusing 🤔 since it can override your theme settings even if you change them directly. It might fly as a third-party thing, but definitely not for direct inclusion to Vencord 🅰️

maddie480 commented 1 week ago

I'll probably come back with another PR to integrate "different light and dark themes" in theme settings directly, to make it less confusing. Rather than following its own schedule, it could just rely on the active Discord theme, and "sync with system" would give auto theme switching for free.

... But before I can personally use that, there's still the mystery of "why does 'sync with system' always end up setting the theme to Light on my computer" left to solve 🤔 It's either a Chromium bug or a skill issue from me, still not sure. In the meantime, I turned this PR into a third party plugin: https://github.com/maddie480/Vencord-AutoThemeSwitcher