search

Vendicated / Vencord

The cutest Discord client mod
https://vencord.dev
GNU General Public License v3.0
9.02k stars 1.28k forks source link

IgnoreActivities: Add option for blacklist filter #2712

Closed Covkie closed 2 months ago

KannaDev commented 3 months ago

Aren't you referring to this, which already exists? image Also, all you have done is rename the variables it seems, and add yourself as a contributor. Making this a pointless PR.

Mind showing what changes this does?

Covkie commented 3 months ago

This is mainly a change for Vesktop users as the menu you're referencing does not exist. What this does is allow users to switch the "Filter List" to a blacklist so duplicate RPC detection can be blocked. image In this image you can see that genshin is detected as a "process" and via ipc. IPC is when the game itself adds rpc support and process is when discord scans the running processes and sees the game running. This results in duplicated playing entries: image

Automatic filtering is possible but the issue arises of how to determine if a process is a dupe of ipc so I just implemented a manual blacklist for users.

Without this patch the above desired "blacklisting" is tedious as a user would need to toggle Ignore Playing and manually add every single game they DO want to work to the Filter List. The below image shows only two entries; Genshin impact and Vivid/Stasis process blocking image

Nuckyz commented 2 months ago

Thank you!