Vendicated / Vencord

The cutest Discord client mod
https://vencord.dev
GNU General Public License v3.0
8.58k stars 1.21k forks source link

[Bug] XSOverlay Notifications Don't show PFP #2787

Closed TypicalZedF closed 1 week ago

TypicalZedF commented 4 weeks ago

Discord Account

typicalzedf

What happens when the bug or crash occurs?

When the plugin is enabled and a notification is displayed, it fails to show a profile picture correctly and instead shows a gray icon. image

What is the expected behaviour?

The message should correctly show a profile picture as shown below image

How do you recreate this bug or crash?

  1. You must have SteamVR with XSOverlay installed of course. The XSOverlay Plugin should also be enabled!
  2. Have a buddy send you a message while you're in VR! You'll get no profile picture in the notification!

Errors

There seem to be no errors that I can gather, this is more of a visual bug of sorts or the plugin is failing to grab users profile pictures or is failing to display it properly.

Request Agreement

TypicalZedF commented 4 weeks ago

Another bug I'd like to report on the side of this is the XSOverlay seems to ignore the size of the message and it breaks the pop-up showing the text breaking out of the notification bubble. Perhaps if the notification is very long.. only show the first few words followed with "..." to show there is more in the message?

nyakowint commented 4 weeks ago

Any faults in the notification itself you can blame xiexe for... but I'll fix up the profile picture thing right now

nyakowint commented 3 weeks ago

Another bug I'd like to report on the side of this is the XSOverlay seems to ignore the size of the message and it breaks the pop-up showing the text breaking out of the notification bubble. Perhaps if the notification is very long.. only show the first few words followed with "..." to show there is more in the message?

I cannot reproduce this, and regardless is something you should create a bug report with XSOverlay's dev instead.

TypicalZedF commented 5 days ago

Is this fixed? It was closed and marked as complete but I didn't notice a fix.

nyakowint commented 5 days ago

i didnt fix your second comment, cause that is not really an issue with the vencord plugin

the linked pr fixes what was originally reported in this issue, and it works from my testing (just now).. if you are having a different issue you'll need to open a new issue and elaborate, or send some logs or something

TypicalZedF commented 5 days ago

The images are still gray as per the original intent of the reported issue. After checking for updates, there is not update available for the XSOverlay Plugin and images still are not loading for the notifications

nyakowint commented 5 days ago

What build of XSOverlay are you running (check in their settings ui)/are you using a beta branch? where is the notification coming from (group chat, server, dm...)? if one of the former, does it have a picture set? I cannot reproduce the same issue post-merge

TypicalZedF commented 5 days ago

I'm running the latest live branch (can't open VR atm so I can't give you the exact number but I checked to make sure I wasn't on the beta branch on steam) What do you mean picture set?

Vendicated commented 5 days ago

use our support channel for support