search

Vendicated / Vencord

The cutest Discord client mod
https://vencord.dev
GNU General Public License v3.0
9.04k stars 1.28k forks source link

Add invert option to dearrow plugin #2818

Closed electricsteve closed 2 months ago

electricsteve commented 2 months ago

Fix #2783 Just need feedback if the option should be marked restart needed. (line 174)

Vendicated commented 2 months ago

why do you need feedback for if a restart is needed? it simply depends on if the option can apply immediately or needs a restart to work

EDM115 commented 2 months ago

@Vendicated from what I understand the option will have an immediate effect but will not work retroactively on already dearrowed embeds, unless the user reload their client

electricsteve commented 2 months ago

Yes, its just idk if it is worth requiring a restart.

Vendicated commented 2 months ago

ah i see. that's fine

electricsteve commented 2 months ago

Yea ok but my question is still not answered, @EDM115 what do you think?

EDM115 commented 2 months ago

I believe it's alright, if users want to see changes on their old embeds that are already dearrowed they just have to refresh discord or close & reopen, which isn't a big problem
I don't think that this setting needs a restart to work out of the box

electricsteve commented 2 months ago

Ok, will remove comment in a few min, currently eating.

Nuckyz commented 2 months ago

Instead of being an option to invert we should do something like how ShowHiddenChannels does: image

Every time you click the toggle button it also updates the setting, so it remembers what you last chose

electricsteve commented 2 months ago

Wtf is that option name

electricsteve commented 2 months ago

Instead of being an option to invert we should do something like how ShowHiddenChannels does: image

Every time you click the toggle button it also updates the setting, so it remembers what you last chose

OK will do that

electricsteve commented 2 months ago

But wait the name of that setting contradicts the function, because it isn't the default, right?

electricsteve commented 2 months ago

(Spelling mistake)

Nuckyz commented 2 months ago

But wait the name of that setting contradicts the function, because it isn't the default, right?

It's the default value which is applied the next time you view the button where it's used

Nuckyz commented 2 months ago

Thank you for the contribution!

electricsteve commented 2 months ago

NP! also I didn't notice enabled didn't need to be inverted. LOL

Nuckyz commented 2 months ago

NP! also I didn't notice enabled didn't need to be inverted. LOL

no worries, my suggestion was wrong too, I only noticed after testing haha