Vendicated / Vencord

The cutest Discord client mod
https://vencord.dev
GNU General Public License v3.0
9.04k stars 1.28k forks source link

feat(Plugin): AccountPanelServerProfile #2836

Closed relitrix closed 1 month ago

relitrix commented 2 months ago

I don't know if such a basic feature has been implemented before me, but anyway

изображение

Nuckyz commented 2 months ago

Maybe name it OwnProfileRoles?

Vendicated commented 2 months ago

is the intent of this that pressing your own profile in the bottom left will show server info? it's not very clear what this is supposed to do

Nuckyz commented 2 months ago

is the intent of this that pressing your own profile in the bottom left will show server info? it's not very clear what this is supposed to do

true, we need to make it clearly this targets the bottom left profile

relitrix commented 2 months ago

if the current desc isn't clear enough, then what about this?

Allows you to view your roles for the currently open server in your profile at the bottom left, without having to look at your server profile from another place, like the member list

Nuckyz commented 2 months ago

I'm thinking rename the plugin to AccountPanelRoles and change the description to Allows you to view your roles in the current server through the account panel in the bottom left, without having search for your server profile in another place, like the member list

Nuckyz commented 2 months ago

or maybe keep the name and just change the description

Scyye commented 2 months ago

I'm thinking rename the plugin to AccountPanelRoles and change the description to Allows you to view your roles in the current server through the account panel in the bottom left, without having search for your server profile in another place, like the member list

Allows you to view your roles in the current server through the account panel in the bottom left, without having to search for your server profile in another place, like the member list

relitrix commented 2 months ago

saw the discussion on discord and thought maybe adding something like a server name/tag above roles would improve usability? i don't think the ability to switch between user and member profile would be easier to maintain and I can't imagine how it would be from UX perspective. one more click to just see roles?

Nuckyz commented 2 months ago

saw the discussion on discord and thought maybe adding something like a server name/tag above roles would improve usability? i don't think the ability to switch between user and member profile would be easier to maintain and I can't imagine how it would be from UX perspective. one more click to just see roles?

I'll experiment with it switching the member profile and see what I can do

Nuckyz commented 2 months ago

I got it to use the other popout, now I just need logic to choose when to use it or not

image

Nuckyz commented 2 months ago

I was able to make it, however pretty much all of the code changed. What's your thoughts on it?

https://github.com/user-attachments/assets/0ea0285d-8ec6-4d23-b9ad-04dc129fbc2a

If we proceed like this I can push the changes to this pull request, but I would also prefer to have my name moved as the first author since I had to re-do everything

relitrix commented 2 months ago

I was able to make it, however pretty much all of the code changed. What's your thoughts on it?

i guess it's fine. but i would like to add checkbox "open server profile on left mouse button" to context menu

I would also prefer to have my name moved as the first author since I had to re-do everything

fair enough

Nuckyz commented 2 months ago

i guess it's fine. but i would like to add checkbox "open server profile on left mouse button" to context menu

will do

relitrix commented 2 months ago

will do

ok, and you left me no reasons to be in devs constant, bruh

Nuckyz commented 2 months ago

will do

ok, and you left me no reasons to be in devs constant, bruh

do you wanna do it then? I wasn't planning to remove you, and I also didn't do any of the changes discarding your work, I just knew it was gonna way more complicated so I chose to do it

relitrix commented 2 months ago

will do

ok, and you left me no reasons to be in devs constant, bruh

do you wanna do it then? I wasn't planning to remove you, and I also didn't do any of the changes discarding your work, I just knew it was gonna way more complicated so I chose to do it

adding a checkbox shouldn't be something hard, so at least let me to do it

UPD: alright, i think it's wrong to ask for smth like this. do as you wish

Nuckyz commented 1 month ago

I've pushed the new implementation, give me your thoughts

relitrix commented 1 month ago

fixed inconsistency in position between user and server profile. in overall it is incredible. thank you

Nuckyz commented 1 month ago

fixed inconsistency in position between user and server profile. in overall it is incredible. thank you

Thanks for fixing that, I noticed it but didn't think of trying to fix

Nuckyz commented 1 month ago

Thanks a lot for the contributions!