VendingOnTime / server-vot

VendingOnTime's API services
http://vendingontime.com
Apache License 2.0
2 stars 0 forks source link

Delete comments #12

Closed msalegre closed 7 years ago

codecov[bot] commented 7 years ago

Codecov Report

Merging #12 into master will decrease coverage by 4.91%. The diff coverage is 43.54%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #12      +/-   ##
============================================
- Coverage     77.16%   72.24%   -4.92%     
- Complexity      195      207      +12     
============================================
  Files            27       34       +7     
  Lines           486      562      +76     
  Branches         78       92      +14     
============================================
+ Hits            375      406      +31     
- Misses           79      124      +45     
  Partials         32       32
Impacted Files Coverage Δ Complexity Δ
...e/backend/models/bodymodels/person/SignUpData.java 74.32% <ø> (ø) 44 <0> (?)
...ngontime/backend/routes/utils/JSONTransformer.java 100% <ø> (ø) 2 <0> (ø) :arrow_down:
...m/vendingontime/backend/services/LogInService.java 88% <ø> (ø) 6 <0> (ø) :arrow_down:
...ndingontime/backend/routes/utils/HttpResponse.java 93.33% <ø> (ø) 8 <0> (ø) :arrow_down:
...vendingontime/backend/routes/utils/RESTResult.java 59.25% <ø> (ø) 9 <0> (ø) :arrow_down:
...backend/services/utils/DummyPasswordEncryptor.java 66.66% <ø> (ø) 2 <0> (ø) :arrow_down:
...ontime/backend/routes/utils/RESTResultFactory.java 100% <ø> (ø) 3 <0> (ø) :arrow_down:
...time/backend/repositories/JPAPersonRepository.java 92.85% <ø> (ø) 26 <0> (ø) :arrow_down:
.../vendingontime/backend/services/SignUpService.java 100% <ø> (ø) 4 <0> (ø) :arrow_down:
...backend/services/utils/BusinessLogicException.java 100% <ø> (ø) 2 <0> (ø) :arrow_down:
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fcdc6e7...9a50cfa. Read the comment docs.

agonper commented 7 years ago

Nos tenemos que acordar de arreglar todo lo que hay en los comentarios de la code review, lo dejo para la siguiente pull request