search

Venemo / node-lmdb

Node.js binding for lmdb
MIT License
361 stars 72 forks source link

Change prebuild infrastructure to use prebuildify #162

Closed Raynos closed 4 years ago

Raynos commented 4 years ago

https://github.com/prebuild/prebuildify and https://github.com/prebuild/node-gyp-build

It looks like the prebuild module has been superceeded by prebuildify

The approach of the latter is to put all the prebuilt binaries in the npm tarball. This replaces the prebuild-install library which downloads binaries at install time.

If the binaries already exist in the npm tarball then there's no need to do extra work at install time.

kriszyp commented 4 years ago

Switched to using prebuildify. Feel free to check if I am doing correctly, since it seems that it is only prebuilding for Windows, since I am doing dev on Windows. Or maybe that's a good thing, because Windows is the hardest OS to get binary addons to build?

Raynos commented 4 years ago

Thanks kris ! I’ll take a look when I get a chance