search

Venom1991 / refind-btrfs

Generate rEFInd manual boot stanzas from Btrfs snapshots
GNU General Public License v3.0
144 stars 8 forks source link

"disabled" not handled #39

Open UltraBlackLinux opened 1 year ago

UltraBlackLinux commented 1 year ago

the keyword disabled (see refind sample config) is not handled. Instead refind-btrfs returns ERROR (refind_btrfs.state_management.refind_btrfs_machine/refind_btrfs_machine.py/run): Boot stanza is not matched with the partition!

Venom1991 commented 1 year ago

These boot stanzas (the ones in which the "disabled" keyword is present) are completely ignored. This error could be caused by a legitimate problem with the found boot stanza.

UltraBlackLinux commented 1 year ago

adding "disabled" causes the error. Removing it also removes the error. The boot stanza is bootable and works as expected

Venom1991 commented 1 year ago

I don't quite understand what you're trying to say. Boot stanzas with the "disabled" keyword are ignored by both rEFInd and refind-btrfs.

You could try pasting the boot stanza's definition here.

UltraBlackLinux commented 1 year ago

I found out, what's happening: If two menu entries exist which both boot the same kernel, an error is thrown. Naturally you disable one entry. You are now left with a different error: ERROR: Boot stanza is not matched with the partition!

Tl;Dr: if two menu options with the same kernel exist, even though one is disabled, an error is thrown. One that doesn't even make much sense from a user's perspective