search

Venom1991 / refind-btrfs

Generate rEFInd manual boot stanzas from Btrfs snapshots
GNU General Public License v3.0
144 stars 8 forks source link

Fix typographic error #9

Closed simonwiles closed 3 years ago

simonwiles commented 3 years ago

Do you welcome PRs for typos like this?

Venom1991 commented 3 years ago

Do you welcome PRs for typos like this?

Of course, why not? I've added a comment to your commit because I'm not exactly sure I've made a mistake? Then again, I'm not a native speaker so I'd like an explanation, if you're up for it.

EDIT: I've replied to your comment on Reddit, assuming that you're wilo108. If not, ignore it.

simonwiles commented 3 years ago

No worries -- I've added a comment to explain it (it can often be difficult to explain grammatical aspects of one's native languages -- especially in English were the grammar is so irregular and where we tend not to be taught the grammatical structures in school).

Please also let me take this opportunity to thank you for this tool. I'm using btrfs as my root filesystem for the first time, and this tool is a real boon to help me leverage the advantages. I got it set up last night, and so far it seems to be working just great.

Venom1991 commented 3 years ago

Please also let me take this opportunity to thank you for this tool. I'm using btrfs as my root filesystem for the first time, and this tool is a real boon to help me leverage the advantages. I got it set up last night, and so far it seems to be working just great.

I'm glad that you find it useful. Also, Btrfs requires some looking after, post-install, so be sure to check out btrfsmaintenance (same owner as btrfs-progs), as well, if you haven't already (AUR package). Interestingly, the Arch wiki page doesn't appear to mention this collection of scripts and I'm not quite sure why that is.

simonwiles commented 3 years ago

Thanks for the reference -- I hadn't found this package, and it's clearly going to be very useful!