search

Venomalia / UniversalDynamicInput

a custom button pack for dolphin that supports over 150 games!
Creative Commons Zero v1.0 Universal
131 stars 15 forks source link

Second controller generates unknown icons #154

Open Tom3s opened 1 year ago

Tom3s commented 1 year ago

Game Name?

Mario Party 4-7, MKWii, Double Dash, SSBB

Game ID?

GMPE01,GP5E01,GP6E01,GP7E01,RMCE01,GM4E01,RSBE01

Input device ID?

Xinput/1/Gamepad

Dolphin version?

5.0-17995

Operating System?

Windows 10

Describe the bug.

Setting the first Gamecube controller port to the secondary windows controller (Xinput/1/Gamepad instead of Xinput/0/Gamepad) will generate question mark icons (ex. Mario Party 4) or just use the default textures.

The supported device section only lists Xinput/0/Gamepad, so I assume Xinput/1/Gamepad is considered an unknown device.

Expected behavior.

Regardless of windows number of the controller, the correct icons should appear

Possible Fixes

Adding a new (Xinput/1/Gamepad) entry to the .json files seems to solve the issue. So some regex style device name matching (Xinput/[0-9]/Gamepad) instead of exact match could solve it.

Venomalia commented 1 year ago

regex is not supported by dolphin at the point and making several entries for each controller is a bit inefficient. iwubcode would like to revise this feature this year, then it will be possible.