Venomalia / UniversalDynamicInput

a custom button pack for dolphin that supports over 150 games!
Creative Commons Zero v1.0 Universal
131 stars 15 forks source link

Run automated fixes on Pull Request #220

Closed Avasam closed 4 months ago

Avasam commented 5 months ago

Follow-up to #217 . If this is accepted, the next step would be to sign-in on https://pre-commit.ci/ and connect it to this repo. (it's the CI autofixes version of https://pre-commit.com) .

Added autoformatting and basic linting fixes for YAML, JSON, Markdown and Python files. As well as autofixes for mixed-line-ending, case-conflict trailing whitespaces and end-of-file newline.

You can run locally using:

You can run on all files using pre-commit run --all-files (see #221 for an initial run on all files)

Devs who enjoy pre-commit git hooks (I don't, some do), can also now use this as a pre-commit hook on their own accord using pre-commit install

Example run: image

Venomalia commented 5 months ago

I am not a fan of formatting the json files, "Device": [[0.0, 512.0, 2048.0, 1536.0]] you should use the same formatting as the DolphinDynamicInputTextureCreator tool.

otherwise i don't see any problems and it would be a good thing to have, thanks for making the effort

Avasam commented 5 months ago

I'll see if I can, otherwise I'll just omit the formatter or use a different one.

Indent fixes are still relevant though.

I prefered showing you the possibility/difference it makes, then reverting if disliked.

Avasam commented 4 months ago

@Venomalia The joys of an overly-opinionated formatter ^^ I excluded JSON files from the prettier hook and added a json formatting hook provided by pre-commit directly.

Venomalia commented 4 months ago

Looks good! I guess I can merge it and then create a pre-commit hook.