Venryx / vscode-vtools

A collection of small tools for Visual Studio Code.
MIT License
21 stars 10 forks source link

vscode 1.28 update fixes #14

Closed jBrizzle closed 5 years ago

jBrizzle commented 5 years ago

Correcting the terminal toggling behavior after the changes made to the workbench.action.terminal.toggleTerminal command in Visual Studio Code v1.28.

jBrizzle commented 5 years ago

To summarize the issue introduced in v1.28: The toggling behavior of panels (terminal, output, problems, debug console) changed in version 1.28. The old behavior was:

The new behavior is:

This bolded portion above is the cause of the issue. Because it will now focus on the terminal if it is not already focused, we are unable to focus on the editor at all. Each attempt just results in the terminal being opened and focused.

miltoncandelero commented 5 years ago

this is referenced on #15 (stating this so that the issue gets the info about this commit)

Venryx commented 5 years ago

Thanks. I'll take a look at this pull request soon and release a new version once I've reviewed it. (not at my desktop atm)

Venryx commented 5 years ago

I merged the change in manually and have updated the extension, v1.0.5. Confirmed working in vscode 1.28.1.

Thanks for the help.