search

Ventan00 / quanda

quanda is a service for questions and answers
Apache License 2.0
2 stars 0 forks source link

Code refactoring #110

Open Ventan00 opened 2 years ago

Ventan00 commented 2 years ago

When do you want to discuss

And decide how to divide between us things to do.

pnarozniak commented 2 years ago

I', free on wednesday.

Ventan00 commented 2 years ago

18:00 is ok for you?

Patrykoss commented 2 years ago

Can we meet around 19:00 tomorrow?

Ventan00 commented 2 years ago
  1. Docs should be writen in english. Endpoints, Interface methods, Extension methods, values in config
  2. HttpService should be moved to folder Services
  3. HttpResponseWrapper should me moved to models
  4. Models from shared should be moved to Server
  5. Config variables should be unified to c# standard
  6. Repositories should be merged (interfaces and repositories)
  7. Razor pages always should contain only html. We should separate .cs .css and razor
  8. Create quanda-auth server and separate endpoints from user
  9. Client/Shared - used on multiple pages, others in Components ordered by folders. When Shared component has multiple subcomponents, then create folder in shared/component name and put all files to this folder
  10. Remove "Component" from components.
  11. Predefined nomenclature of function names ( clicks: handleOnUsersClick(), callbacks: on{Event}())
  12. Pages/Auth/Log,reg pages/Auth/Recover/...
  13. DTO in folders with controller names and function names + request/reposne + dto (GetUsersResponseDTO in DTOs/Users). DTOs used in multiple controllers go to /Shared
  14. Enums in DTOs
  15. urls small-case-dash-separated
  16. no async in controllers

    Cleanup code

Ventan00 commented 2 years ago

Ventan: Shared xlegodroid: Client Patrykoss: Server