search

Ventero / FRESteamWorks

SteamWorks API for AIR applications
Other
83 stars 27 forks source link

Added GetEncriptedAppticket(), GetSmallFrienAvatar(), GetMediumFriendAvatar() #43

Closed kiripu closed 6 years ago

kiripu commented 7 years ago

Hello. I'm added new method for encrypted app ticket request https://partner.steamgames.com/doc/api/ISteamUser#GetEncryptedAppTicket And also added methods for friend avatar bitmap data https://partner.steamgames.com/doc/api/ISteamFriends#GetSmallFriendAvatar https://partner.steamgames.com/doc/api/ISteamFriends#GetMediumFriendAvatar

Ventero commented 7 years ago

Wow, thanks so much! I will review this in more detail tomorrow, but at a first glance it looks pretty good!

kiripu commented 7 years ago

Hello. Thank you for your feedback. I will fix it next day.

Ventero commented 6 years ago

@kiripu Hey, just wanted to follow up on this PR - did you maybe forget to push your commits? Just want to make sure I don't end up duplicating work you've already done if I merge the PR as-is and fix my nitpicks myself.

kiripu commented 6 years ago

@Ventero Hello. Sorry. Was very busy this month. I didn't finish this yet. I will push all changes today

kiripu commented 6 years ago

@Ventero I just finished to update code. Have no idea about enum which GetEncryptedAppTicket method should return. Are you will not against if i leave it decision up for you?

Ventero commented 6 years ago

Sorry, what I meant with my comment about GetEncryptedAppTicket was that I don't understand why the method in the Steam SDK returns a bool instead of enum - your wrapper implementation correctly mirrors the SDK implementation. So no need to change anything.

Also, the code look fantastic! Thank you so much for your contribution!

kiripu commented 6 years ago

@Ventero Hello. Thank you. Would you please update and share extensions binaries?

Ventero commented 6 years ago

@kiripu I'll try to get a new build up by Thursday - want to do some refactoring first, and get the Linux version up to par again.

Ventero commented 6 years ago

@kiripu Uploaded new builds to http://dump.ventero.de/FRESteamWorks/v0.7/.