search

Ventero / FRESteamWorks

SteamWorks API for AIR applications
Other
83 stars 27 forks source link

In-app purchase (MicroTxnAuthorizationResponse_t) callback #7

Closed Unsanctioned closed 10 years ago

Unsanctioned commented 10 years ago

Added support for the MicroTxnAuthorizationResponse_t callback from Steam that queues results, plus a method to retrieve results in the order callbacks were received.

Ventero commented 10 years ago

Nice, thanks! I'm going to leave some nitpick comments on the diff, it would be great if you could fix them. Thanks a lot for your contribution!

Unsanctioned commented 10 years ago

I'll take a look at these and get them fixed up.

On Apr 26, 2014, at 3:09 AM, Ventero notifications@github.com wrote:

Nice, thanks! I'm going to leave some nitpick comments on the diff, it would be great if you could fix them. Thanks a lot for your contribution!

— Reply to this email directly or view it on GitHub.

Unsanctioned commented 10 years ago

Fixed up all of the minor nitpicks. Should be ready to go.

Ventero commented 10 years ago

Looks good! I've taken the liberty of rebasing your changes against master and pushed them manually. Thanks again for your contribution!

Ventero commented 10 years ago

Just a quick FYI: I've changed the API slightly to return a full object instead of just the transaction ID. As the transaction ID and result would be passed to the application through two different mechanisms (event result + function call return value), making it possible to get a mismatch between ID and result (e.g. by not immediately calling microTxnOrderIDResult() after receiving the event). By returning an object containing both the ID and result, this is much harder to get wrong.

Unsanctioned commented 10 years ago

Sounds like a good change.