Venture-Stream / aquacadabra-2.0

Forked from Shopify/Dawn
0 stars 0 forks source link

Just created this new listing with a load of images - the little scroll arrows appear at the top & bottom of them but it seems there's no max height? #193

Closed liamcottrell1 closed 1 month ago

liamcottrell1 commented 1 month ago

Just created this new listing with a load of images - the little scroll arrows appear at the top & bottom of them but it seems there's no max height?

https://www.bugherd.com/projects/396350/tasks/109

liamcottrell1 commented 1 month ago

@Ray Woods this should be sorted now

liamcottrell1 commented 1 month ago

@Sam Derbyshire thanks! Sorry to be a pain, could we have the bottom of the bottom arrow align with the bottom of the image please? (and I guess line up the images appearing between them so there's no dodgy gap)

liamcottrell1 commented 1 month ago

@Sam Derbyshire sorry I just realised the image size is responsive but the scroll bit isn't.. so actually at my full screen the scroll bit is just under the size of the main image, but on a smaller width it extends below it.

In which case, I guess let's ignore the bottom aligning request - unless you can just have a quick look and see what you think is best, happy to leave it with you

liamcottrell1 commented 1 month ago

Hi @Ray Woods I've just deployed a possible fix, could you check it on your end for me please?

liamcottrell1 commented 1 month ago

@Sam Derbyshire thanks mate, looks good to me!