Venture-Stream / aquacadabra-2.0

Forked from Shopify/Dawn
0 stars 0 forks source link

Seems to be an issue with variant images. This listing has just one group image and nothing assigned to the individual variants - normally this means when you use the variation dropdown the displayed image just doesn't change like usual, but here it's r... #94

Closed liamcottrell1 closed 2 months ago

liamcottrell1 commented 3 months ago

Seems to be an issue with variant images. This listing has just one group image and nothing assigned to the individual variants - normally this means when you use the variation dropdown the displayed image just doesn't change like usual, but here it's removing the group image, presumably trying to switch to a variant photo which doesn't exist!

Ideally everything would have a group/parent image and images attached to each variant, but not everything does so we need that covered please!

https://www.bugherd.com/projects/396350/tasks/58

liamcottrell1 commented 2 months ago

This listing with no variant images still just displays nothing once you select a variant...

we need it to keep the group image displaying if you switch to a variant without an image

liamcottrell1 commented 2 months ago

another example where the image just goes blank if you pick a variant without an image (again I know we should really have images on all of them but we can't check or fix this in bulk so it needs to work in all instances please)

liamcottrell1 commented 2 months ago

@Ray Woods I've just deployed a fix for this, would you be able to clear your cache/view the site in a private tab and check again for me please?

liamcottrell1 commented 2 months ago

thanks Sam, that's done the trick!