search

VentureCraft / revisionable

Easily create a revision history for any laravel model
http://twitter.com/duellsy
MIT License
2.55k stars 349 forks source link

way/database package support #65

Closed SuperlativeEntity closed 10 years ago

SuperlativeEntity commented 10 years ago

Possible boot conflict. Need revisionable to gel with way/database (which extends directly from Eloquent)

duellsy commented 10 years ago

This is because they are both fighting over the boot method

duellsy commented 10 years ago

This will be resolved in v2.0

SuperlativeEntity commented 10 years ago

Thanks Man

GrahamCampbell commented 10 years ago

It would be cool if version 2 was php 5.4+ upwards only so we could get rid of the duplication, and just use the trait.

SuperlativeEntity commented 10 years ago

@GrahamCampbell This worked well for me - watson/validating. It also ignores the current id in terms of validation during an update

duellsy commented 10 years ago

@GrahamCampbell oh it will be, that's a definite! It will also require illuminate/support >= 4.2.6, so we can use:

bootRevisionableTrait() instead of overriding boot()

https://github.com/laravel/framework/blob/master/src/Illuminate/Database/Eloquent/Model.php#L305

(at least, I think that's when this came available)