search

Venturocket / angular-slider

Slider directive for AngularJS.
MIT License
262 stars 121 forks source link

Remove modernizr inputtype check #4

Closed 0x6a68 closed 10 years ago

0x6a68 commented 10 years ago

Hey! First of all, i really appreciate that you are maintaining the original angular-slider. As long as Modernizr just checks if inputtype range is supported, i do not think that Modernizr is really needed.

drgould commented 10 years ago

Thanks. The travis build failed, but yeah that's probably a better way to check for compatibility. I'm also considering dropping support for browsers that don't support the range input type in a future release. Not quite yet though since the sites where I use this still get a not insignificant amount of traffic from such browsers (really only IE9).

0x6a68 commented 10 years ago

Oh. I have not taken that you are using Travis and that the build has failed, going to fix that.

drgould commented 10 years ago

Don't waste your time. I'm going to be reworking a lot of things with the slider, so it's not really a big deal that the build failed.

0x6a68 commented 10 years ago

Hihi. There is no time wasting :)

Refactoring is a very good point. I saw a lot of programming styles in the source, maybe using jshint? If you need any help for the revamp, i am your man for this :) let me know!