search

Venturocket / angular-slider

Slider directive for AngularJS.
MIT License
262 stars 121 forks source link

IE11 memory leak #84

Open jsolis opened 9 years ago

jsolis commented 9 years ago

Using windows 7 and 8.1 running IE11, versions 0.3.0 - 0.3.2 of this component causes the memory usage to shoot up until the browser tab becomes unresponsive and as a result, I couldn't get a heap dump. Windows 10 / IE11 worked properly, as did other versions of IE on various OS versions.

When I rolled back the plugin to 0.2.5, the component functioned properly on windows 7/8.1 IE11.

Also interesting to note is that after the windows update in my windows 7 VM ran, version 0.3.2 worked properly. This makes me believe it's more of an IE11 / windows issue than a code issue, except for the fact that an older version of the component worked everywhere.

I'm going to talk to some of my team to see which way we're going to go, and if we decide to find and fix this issue, we'll send a pull request. Otherwise, I figured at least this might help someone else out who has been seeing this issue.

lewie6 commented 9 years ago

just incase this helps anyone else... had same issue, wrapped all "updateDOM()" calls in double $timeout and it worked. yep, ugly + hacky, but didn't have time to look into proper fix ...

$timeout(function() {
  $timeout(function() {
    updateDOM();
 });
});