search

VerbalExpressions / PythonVerbalExpressions

Python regular expressions made easy
1.63k stars 115 forks source link

Added Python3 support #15

Closed sam-omalley closed 6 years ago

sam-omalley commented 9 years ago

Also includes mehmetkose's and rajatkhanduja's changes.

mattdbr commented 8 years ago

Yes please!

jehna commented 8 years ago

Where are we currently on the Python 3 adoption? I've understood that Python 2.7's sunset date was postponed to 2020.

Would it be considered as a bad practice to make a Python3VerbalExpressions fork, to support both of the platforms? What do you think?

mihai-vlc commented 8 years ago

As long as it is supports both python 2 & 3 I don't see why we should have 2 repos.

mattdbr commented 8 years ago

@jehna I agree with @ionutvmi . As long as it supports both there is no need for two repos.

If it starts breaking (which this version doesn't appear to do) then perhaps 2 repos are needed.

jehna commented 8 years ago

If these are not breaking changes to 2.x version, it's fine to merge them to the repo.

If possible, you could add to the readme.md a note about the compatibility.

sam-omalley commented 8 years ago

Hi @jehna, this version has really minimal changes to make it work on both Python3 and Python2. I've just merged in the latest upstream changes and tested that everything still works for both Python2 and Python3. I have just tested with Python 2.7.11 and 3.5.1, previously I tested in multiple Python 3 versions (but I can't find a record of this).

Can someone else try out this branch and run:

python setup.py develop
python setup.py test

and

python3 setup.py develop
python3 setup.py test
mihai-vlc commented 8 years ago

I will close and reopen to trigger the travis build.

vtitor commented 6 years ago

@omalsa04 Thanks for your pr, but I closed this pr, because python 3 support is already implemented.