Open Warchant opened 2 years ago
@Warchant do you have a list of peers that we want to hardcode?
@blackyblack it turns out mainnet NC does DNS resolution to get peers. And it is already implemented in APM. Just make sure for (1) that all peers found by DNS resolution are used.
I see that DNS IPs are added to the peers table as soon as they are resolved. And we have such a test case for a single IP for a single DNS record. Should we consider (1) as done then? As for (2), I haven't found the ability to download peers list from the connected peers. Should I implement this functionality?
For (2) scratch this. Found some code that looks like it.
@Warchant Also I found that peers may stay in candidates list but not being connected to. It happens if minimum amount of peers has been reached. Do we want to fix this behavior?
@blackyblack
minpeers
active connections. It should connect connect up until minpeers
is reached, then we can accept only incoming connections up until maxpeers
.@Warchant
@blackyblack wow. Okay. Do you have any idea why this may happen https://github.com/VeriBlock/nodecore/issues/369 ?
I was looking at the nodecore peer discovery code and the logs are for SPV app. I will check if there is any difference.
Fixes https://github.com/VeriBlock/vbk-ri-btc/issues/630