VeriBlock / vbk-ri-btc

Bitcoin Core integration/staging tree
https://bitcoincore.org/en/download
Other
4 stars 6 forks source link

ABFI Status not showing correctly on QT Wallet Transaction Details #621

Closed overcookedpanda closed 2 years ago

overcookedpanda commented 2 years ago

Within the config file you can specify bfiendpoint=https://testnet.abfi.veriblock.org/

When someone clicks on the transaction details, it should take the altchain ID (%1) and the txid (%2) and formulate the url as below:

https://testnet.abfi.veriblock.org/%1/chains/transactions/%2

It should then show the 'bitcoinFinality' of the transaction that it gets back from the API.

There are no errors in the log about the API call, and if you manually call the API, you get a valid response.

timstall commented 2 years ago

This corresponds to what one would see in the explorer, such as: https://testnet.explore.vbtc.veriblock.org/tx/f445862c48bebe032cc9c9d4792af59bbdb3eff2132b428db892743efcff8b08 image

Full API: https://testnet.abfi.veriblock.org/16579303907010303/chains/transactions/f445862c48bebe032cc9c9d4792af59bbdb3eff2132b428db892743efcff8b08

Likely code section: https://github.com/VeriBlock/vbk-ri-btc/blob/master/src/qt/transactiondesc.cpp#L123-L198