search

VeriFIT / mata

A fast and simple automata library
MIT License
23 stars 13 forks source link

Self-concatenating for in-place concatenation #349

Closed jurajsic closed 1 year ago

jurajsic commented 1 year ago

Calling aut.concatenate(aut) now breaks everything, we should fix that. Probably it is enough to copy only the original states (up to original aut.num_of_states()).

Also, we should fix that concatenation does not return trimmed automata if we give it trimmed automata. This could be done by checking whether some transition goes into initial states of the second automaton, if not, they are not copied into concatenation.

vhavlena commented 1 year ago

This should be fixed already.

Adda0 commented 1 year ago

Should or is (minus unknown bugs)? Has anyone tried on at least some example?

vhavlena commented 1 year ago

As far as I remember, I have fixed it at some point and there should be some test for that.

Adda0 commented 1 year ago

Great. I am closing this issue, then.