VeriFIT / mata

A fast and simple automata library
MIT License
20 stars 13 forks source link

Refactoring mintermization to MintermizationDomain #355

Open martinhruska opened 1 year ago

martinhruska commented 1 year ago

This PR indtroduces the following changes:

codecov[bot] commented 1 year ago

Codecov Report

Attention: 31 lines in your changes are missing coverage. Please review.

Comparison is base (5143cde) 71.70% compared to head (eac2b49) 73.16%. Report is 46 commits behind head on devel.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## devel #355 +/- ## ========================================== + Coverage 71.70% 73.16% +1.45% ========================================== Files 30 32 +2 Lines 3644 3536 -108 Branches 843 805 -38 ========================================== - Hits 2613 2587 -26 + Misses 736 649 -87 - Partials 295 300 +5 ``` | [Files](https://app.codecov.io/gh/VeriFIT/mata/pull/355?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=VeriFIT) | Coverage Δ | | |---|---|---| | [include/mata/parser/bdd-domain.hh](https://app.codecov.io/gh/VeriFIT/mata/pull/355?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=VeriFIT#diff-aW5jbHVkZS9tYXRhL3BhcnNlci9iZGQtZG9tYWluLmho) | `100.00% <100.00%> (ø)` | | | [include/mata/parser/inter-aut.hh](https://app.codecov.io/gh/VeriFIT/mata/pull/355?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=VeriFIT#diff-aW5jbHVkZS9tYXRhL3BhcnNlci9pbnRlci1hdXQuaGg=) | `89.74% <100.00%> (ø)` | | | [src/bdd-domain.cc](https://app.codecov.io/gh/VeriFIT/mata/pull/355?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=VeriFIT#diff-c3JjL2JkZC1kb21haW4uY2M=) | `100.00% <100.00%> (ø)` | | | [src/mintermization.cc](https://app.codecov.io/gh/VeriFIT/mata/pull/355?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=VeriFIT#diff-c3JjL21pbnRlcm1pemF0aW9uLmNj) | `0.00% <ø> (-34.56%)` | :arrow_down: | | [src/parser.cc](https://app.codecov.io/gh/VeriFIT/mata/pull/355?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=VeriFIT#diff-c3JjL3BhcnNlci5jYw==) | `82.06% <100.00%> (ø)` | | | [src/inter-aut.cc](https://app.codecov.io/gh/VeriFIT/mata/pull/355?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=VeriFIT#diff-c3JjL2ludGVyLWF1dC5jYw==) | `65.16% <90.90%> (+0.31%)` | :arrow_up: | | [include/mata/parser/mintermization.hh](https://app.codecov.io/gh/VeriFIT/mata/pull/355?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=VeriFIT#diff-aW5jbHVkZS9tYXRhL3BhcnNlci9taW50ZXJtaXphdGlvbi5oaA==) | `66.66% <66.26%> (+41.66%)` | :arrow_up: | ... and [7 files with indirect coverage changes](https://app.codecov.io/gh/VeriFIT/mata/pull/355/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=VeriFIT)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Adda0 commented 1 year ago

When the PR is finished, @tfiedor or I will fix the binding before merging the PR.