search

VeriFIT / mata

A fast and simple automata library
MIT License
20 stars 13 forks source link

Inclusion optimization #366

Closed Adda0 closed 11 months ago

Adda0 commented 12 months ago

This PR optimizes inclusion computation using priority queue.

codecov[bot] commented 12 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (bdf0e49) 71.80% compared to head (33efe36) 71.84%. Report is 1 commits behind head on devel.

:exclamation: Current head 33efe36 differs from pull request most recent head 512d54e. Consider uploading reports for the commit 512d54e to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## devel #366 +/- ## ========================================== + Coverage 71.80% 71.84% +0.03% ========================================== Files 30 30 Lines 3643 3644 +1 Branches 836 834 -2 ========================================== + Hits 2616 2618 +2 Misses 735 735 + Partials 292 291 -1 ``` | [Files](https://app.codecov.io/gh/VeriFIT/mata/pull/366?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=VeriFIT) | Coverage Δ | | |---|---|---| | [include/mata/utils/ord-vector.hh](https://app.codecov.io/gh/VeriFIT/mata/pull/366?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=VeriFIT#diff-aW5jbHVkZS9tYXRhL3V0aWxzL29yZC12ZWN0b3IuaGg=) | `69.07% <100.00%> (+0.83%)` | :arrow_up: | | [src/nfa/inclusion.cc](https://app.codecov.io/gh/VeriFIT/mata/pull/366?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=VeriFIT#diff-c3JjL25mYS9pbmNsdXNpb24uY2M=) | `90.82% <100.00%> (+0.58%)` | :arrow_up: | | [src/nfa/delta.cc](https://app.codecov.io/gh/VeriFIT/mata/pull/366?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=VeriFIT#diff-c3JjL25mYS9kZWx0YS5jYw==) | `82.52% <81.81%> (+0.15%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/VeriFIT/mata/pull/366/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=VeriFIT)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Adda0 commented 11 months ago

The reviewers can have a look at the code, but it is not strictly necessary. I will merge the PR later today.