VeriFIT / mata

A fast and simple automata library
MIT License
14 stars 11 forks source link

Jupyter notebook for visualization #370

Closed vhavlena closed 8 months ago

vhavlena commented 8 months ago

Notebook showing possibilities of automata visualisation in mata.

codecov[bot] commented 8 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (1494bd4) 71.80% compared to head (4eee120) 71.82%. Report is 7 commits behind head on devel.

:exclamation: Current head 4eee120 differs from pull request most recent head c721e11. Consider uploading reports for the commit c721e11 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## devel #370 +/- ## ========================================== + Coverage 71.80% 71.82% +0.01% ========================================== Files 30 30 Lines 3643 3642 -1 Branches 836 834 -2 ========================================== Hits 2616 2616 Misses 735 735 + Partials 292 291 -1 ``` | [Files](https://app.codecov.io/gh/VeriFIT/mata/pull/370?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=VeriFIT) | Coverage Δ | | |---|---|---| | [include/mata/utils/ord-vector.hh](https://app.codecov.io/gh/VeriFIT/mata/pull/370?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=VeriFIT#diff-aW5jbHVkZS9tYXRhL3V0aWxzL29yZC12ZWN0b3IuaGg=) | `68.66% <100.00%> (+0.42%)` | :arrow_up: | | [src/nfa/inclusion.cc](https://app.codecov.io/gh/VeriFIT/mata/pull/370?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=VeriFIT#diff-c3JjL25mYS9pbmNsdXNpb24uY2M=) | `90.82% <100.00%> (+0.58%)` | :arrow_up: | | [src/nfa/delta.cc](https://app.codecov.io/gh/VeriFIT/mata/pull/370?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=VeriFIT#diff-c3JjL25mYS9kZWx0YS5jYw==) | `82.52% <81.81%> (+0.15%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/VeriFIT/mata/pull/370/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=VeriFIT)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Adda0 commented 8 months ago

This was badly needed. I will review the PR later today as soon as I can. From the quick glance, the PR seems nice.

vhavlena commented 8 months ago

@kilohsakul maybe wanted to include such a notebook to the paper. Lukas, please look at it.

kilohsakul commented 8 months ago

Krasne! Jeste by to fakt mohlo kreslit horizontalne.

vhavlena commented 8 months ago

I think it is ready for merge.

Adda0 commented 8 months ago

Let me know if you want to remove the commented out lines or merge the PR right away.