Closed koniksedy closed 7 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 73.43%. Comparing base (
485b91e
) to head (f0ac876
). Report is 1 commits behind head on states_with_levels.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
We cannot use Limits::max_state
. We need to probably have two overloaded functions. One with the normal parameters without target state which will inside the function default to nfa.num_of_states()
, and another with explicit target state parameter (the original function). I consider this approach a cleaner solution than the current one since Limits::max_state
is still technically a valid state.
This PR, based on notes from PR-Nfa compose, includes:
nfa::Nfa::insert_word()
,nft::Nft::insert_word()
, andnft::Nft::insert_word_by_parts()
, which now have an optional target state (defaultLimits::max_state
).nft::Nft::insert_identity()
that can create identity transitions for each symbol in a given vector.