search

VeriFIT / mata

A fast and simple automata library
MIT License
20 stars 13 forks source link

Renamed union #412

Closed Adda0 closed 2 months ago

Adda0 commented 3 months ago

This PR resolves the issue with naming the operation union from #172. This PR is a rebase and update of #354.

There are currently two versions of the union operation:

  1. nondeterministic union (the classic union), called union_nondet(), and
  2. union using product construction (performing product construction and adding final states whenever either automaton has the corresponding state in the product state final), called union_product().

The in-place variant of union_nondet() is called unite_nondet_with(), as per the suggestion in https://github.com/VeriFIT/mata/pull/277#discussion_r1272083294.

Another suggestion for the union_nondet() was lang_union().

Adda0 commented 2 months ago

I pushed the agreed upon changes. We will resolve whether to add a general union function in another issue and PR. For now, I will merge the changes, so I can create PRs for other dependent changes.