search

Verigreen / verigreen

Verigreen is a lightweight, server side solution for verification of git commits. It is a gated check-in process which will not allow any failed CI commit to go into an integration/release/any protected branch. We keep it green (hence the name).
Apache License 2.0
57 stars 19 forks source link

"public static" fields should be constant #106

Closed AymanDF closed 8 years ago

AymanDF commented 8 years ago

This pull request is focused on resolving occurrences of Sonar rule squid:S1444 - “"public static" fields should be constant”. You can find more information about the issue here: https://dev.eclipse.org/sonar/rules/show/squid:S1444 Please let me know if you have any questions. Ayman Abdelghany.

soninob commented 8 years ago

@AymanDF - you have Compilation failure in this PR.

AymanDF commented 8 years ago

@soninob Sorry for inconvenience, it has been fixed now.

soninob commented 8 years ago

@AymanDF - properties is a dynamic field - we are using Watchdir to identify changes in the properties file, and just might want this object to be changed. Do you still think that this PR is needed?

AymanDF commented 8 years ago

@soninob In this case I don't think this PR is needed :)