Verigreen / verigreen

Verigreen is a lightweight, server side solution for verification of git commits. It is a gated check-in process which will not allow any failed CI commit to go into an integration/release/any protected branch. We keep it green (hence the name).
Apache License 2.0
57 stars 19 forks source link

Jenkins API - Check if job is still building before returning the status #91

Closed DVir669 closed 8 years ago

DVir669 commented 8 years ago

When building a job, there are many plugins that are manipulating the status of the build. Most common is "trigger\call builds on other projects" -> if the triggered job is blocking the build flow any result from the downstream will result in manipulation of the status.

VG is looking at the job's API to return the status - when it is set the status is returned before the actual job is finished.

To fix it the logical way is to make sure that the build is not running anymore by using: instead of : builds[number,result] Use : builds[number,result,building] and check if building == false before returning the status. Thanks, Dvir

soninob commented 8 years ago

Been fixed by #93