search

VeriorPies / ParrelSync

(Unity3D) Test multiplayer without building
MIT License
4.51k stars 318 forks source link

fix: #48 package-lock.json is not synchronized when build failed #49

Closed kyubuns closed 3 years ago

kyubuns commented 3 years ago

I was unsure of the implementation policy, so I modified it so that it would require the min amount of changes.

314pies commented 3 years ago

Hi kyubuns, I've check out the commit. It looks like the main difference here is instead of checking the Package folder at clone project when it started (by ValidateCopiedFoldersIntegrity's constructor), you also check it from the original editor when clicking the open clone project button.

Can you please explain the reason why you want to do it so?

kyubuns commented 3 years ago

Hi! This is to solve issue #48. In #48, I reported a problem where a project could not be opened if the source code did not pass the build unless the package was updated. The reason is that the ValidateCopiedFoldersIntegrity's constructor is not called when the project is opened if the build does not pass. By updating Packages first from the Original Editor, you create a state where the build will pass correctly.

314pies commented 3 years ago

Make sense, just validated it, thanks!