search

VeriorPies / ParrelSync

(Unity3D) Test multiplayer without building
MIT License
4.51k stars 318 forks source link

Removed copying Packages folder and replaced it with symlinking #63

Closed brogan89 closed 2 months ago

brogan89 commented 2 years ago

Fixes Bug #57

brogan89 commented 2 years ago

Satisfies feature request #58

mikz commented 2 years ago

This was revered in https://github.com/VeriorPies/ParrelSync/commit/f3a9c52950bb55c4830c9cd474d4b804a174245e because of https://github.com/VeriorPies/ParrelSync/issues/23

Probably better to double down on https://github.com/VeriorPies/ParrelSync/commit/164651058b86d4491656bf0f970e7d679298deef rather than going back. Unity does not really like that folder symlinked.

Or can you confirm that is no longer the case?

brogan89 commented 2 years ago

This was revered in f3a9c52 because of #23

Interesting. I"ve never experienced that issue.

Or can you confirm that is no longer the case?

I can only confirm for the version of Unity that I'm using which is the tech stream 2021.2.8 and a few patch versions before that. I've been using my fork of the project for the last few months and it's been fine, no issues updating packages.

mikz commented 2 years ago

Well, it was not really problem about updating packages. But Unity showed a window "Resolving packages" for a few seconds whenever you changed focus between windows or when some script was changed. That was quite annoying.

mikz commented 2 years ago

I tried it with 2021.1.28 and I can't reproduce #23 but entirely new issue appears. If I open two Rider windows it starts consuming 100% CPU and overriding each other's packages.

I think this behaviour should be configurable as depending on the workflow it might cause issues.

314pies commented 2 years ago

Hi folks!

Thanks for bringing this up; Will take a deeper look when available.

mikz commented 2 years ago

Maybe just a button in menu to force the sync would be ok too. You don't change packages very often.

fangjunzhou commented 2 years ago

Maybe just a button in menu to force the sync would be ok too. You don't change packages very often.

I've added a preference checkbox to let users decide whether to sync Package, I'm not sure if that helps. Latter I will try to add another feature to force sync the Package folder. I still think this is important. At least for me, I changed package directory very often.

kamyker commented 1 year ago

I tried it with 2021.1.28 and I can't reproduce #23 but entirely new issue appears. If I open two Rider windows it starts consuming 100% CPU and overriding each other's packages.

I think this behaviour should be configurable as depending on the workflow it might cause issues.

No issues for me in Unity 2023, imo Package symlinking should be on by default.

RunninglVlan commented 10 months ago

README is also confusing - it tells that Packages are symlinked, when in fact they're just copied