Closed MartinGallauner closed 10 months ago
Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
Everything works perfectly! This gives me a good starting point to work off of. Could you please fix the merge conflicts real quick so that I can merge it? Thanks!
@VerisimilitudeX I resolved the merge conflict and all findings in the build pipeline by now. There is only one false positive left because I wrote a test using a mock key. Can you tell me how to skip that and merge?
Well, most secret scanning workflow support a "suppress warning" feature, although GitGuardian doesn't unfortunately. For example: @SuppressWarnings("squid:S1234") // this is to ignore SonarQube's rule, replace "S1234" public class MyClass { ... }
I think I can go ahead and merge this and add this test file to the list of GitGuardian's exclusion list later. Thanks for the PR btw!
@MartinGallauner one last thing - could you please add some documentation under docs/* that tells devs how to run the features that you just added in this PR? I would really appreciate that. Thanks!
@VerisimilitudeX Sure thing! I will add the docs to the next iteration when there is some actual functionality.
Hi!
Regarding this issue. In this pull request, I introduced many changes, and I'm sure there will be a lot of feedback.
My primary goal was to don't break any existing functionality. The secondary goal was to introduce Spring Boot and a first simple controller class offering two endpoints concerned with getting/setting the openai api-key. Maybe we want to stick to the current solution for security reasons, though.
This is what I did:
DNAnalyzerApplication
with another main method. I did that so anyone can consciously run the application either in the current (cli/gui) version or in the future webservice version.What's missing? A lot.
DNAAnalysis
record by domain and presentation logic. If we stick to clean architecture, I would implement something like a SystemOutAdapter and keep the domain logic within a service class.