search

Veriteworks / CookieFix

Fix Magento2.2/2.3/2.4 Cookie SameSite attribute
Academic Free License v3.0
65 stars 35 forks source link

Magento 2.1 ,the checkout is not working after applying the fix #14

Open MaalyALkaraki opened 3 years ago

MaalyALkaraki commented 3 years ago

first i would thank you for this fix , I applyed the fix for a Magento 2.1.7 site but the checkout is not working , the log has no reference for the fix ,they are using php7.1,

HirokazuNishi commented 3 years ago

Unfortunately, I didn't test it against Magento2.1.x, because Magento2.1.x was already EOL. You should update it to 2.3 or 2.4 first.

MaalyALkaraki commented 3 years ago

we apply it to magento 2.3.2 and unfortunately we have the same issue .

HirokazuNishi commented 3 years ago

Could you share me more details? How to reproduce? Any screen shots? JS error logs or PHP logs?

MaalyALkaraki commented 3 years ago

-after applying the fix ,it was stopping the add to cart from working, it will just keep spinning , -the php error is : PHP Fatal error: Uncaught Error: Call to a member function getStoreId() on null in /home/wwwsite /public_html/vendor/magento/module-quote/Model/Quote/Payment.php:286. -on js error

HirokazuNishi commented 3 years ago

Please share me more.

We use latest version for M2.3.x customers, but no one reported such case :(

MaalyALkaraki commented 3 years ago
  1. The browser's cookies it test them when it was all on default mode for same-site cookie
    1. I used the latest update for chrome browser . And i tried it on a Magento 2.3.4 : in this case the checkout wat working but the orders was not passed to the admin side , and the same site cookies did not turned to none in the browser after applying the fix . we got this php error m
HirokazuNishi commented 3 years ago

Does your website run full HTTPS? SameSite=None is only allowed with Secure flag.

MaalyALkaraki commented 3 years ago

yes it is