search

Veriteworks / CookieFix

Fix Magento2.2/2.3/2.4 Cookie SameSite attribute
Academic Free License v3.0
65 stars 35 forks source link

Add to cart and other ajax events not working #18

Open dinkeronline opened 3 years ago

dinkeronline commented 3 years ago

@HirokazuNishi can you put some light on the below plugins? are they actually needed and if I remove them what will not work?

` <plugin name="afterGetPath" type="Veriteworks\CookieFix\Plugin\View\Element\Js\AdjustPath" sortOrder="10"/>

`
HirokazuNishi commented 3 years ago

@dinkeronline you have to share me more information about your case (like Magento2 repository required for all issues).

dinkeronline commented 3 years ago

Hi @HirokazuNishi, thank you for this life saver fix. it works well except for the add to cart and other ajax based request are not working properly, it adds SID to the URLs like - https://mydomain.com/customer/section/load/?SID=

My Magento version is 2.3.1, add to cart and other ajax features are working after I removed the plugins declared in frontend/di.xml, since you have created this module it will be easier for you to point out the plugins defined in frontend/di.xml and their uses/impacts if removed.

the 3DS payments are still working after removing the frontend plugins (frontend/di.xml) and I can see the SameSite parameter is set.

tuyennn commented 3 years ago

Has same issue with this on Magento 2.3.4