Veriteworks / CookieFix

Fix Magento2.2/2.3/2.4 Cookie SameSite attribute
Academic Free License v3.0
65 stars 35 forks source link

composer require gives me version 2.4.0 #20

Open arielien opened 3 years ago

arielien commented 3 years ago

Hi,

Thanks for creating this fix!

Im trying to get the code by using composer require. its always gives me 2.4.0 version. The version is different . currently the 'Veriteworks\CookieFix\Rewrite\Stdlib\Cookie\PublicCookieMetadata' class cause an compilation issue => incompatible with 'Magento\Framework\Stdlib\Cookie\CookieMetadata'

i've tried to claer composer cache..

im using Magento 2.4.1

am i missing something?

10x

HirokazuNishi commented 3 years ago

@arielien M2.4.1 has native SameSite cookie feature. Please try dev-master version.

tuyennn commented 3 years ago

@HirokazuNishi @arielien the current declared composer.json doesn't support magento 2.4.0 or 2.4.0-p1, maybe we need to modify it to let it works