VeritoneAlpha / spark-job-rest

Other
33 stars 20 forks source link

Get ip from config as port #2

Closed Sephiroth-Lin closed 9 years ago

Sephiroth-Lin commented 9 years ago

Get ip from config is more reasonable then set 0.0.0.0 in the code directly. Now user can set ip in application.conf like below:

appConf{

this ip on which to deploy the apis

web.services.ip=9.91.12.117
# the port on which to deploy the apis
web.services.port=8097
    ...

}

raduchilom commented 9 years ago

@Sephiroth-Lin , can you please add the web.services.ip property in the application.conf file, just like you did in the comment above(with the default ip 0.0.0.0) ?

Sephiroth-Lin commented 9 years ago

@raduchilom, I have add the web.services.ip property in the application.conf file, thank you!

raduchilom commented 9 years ago

@Sephiroth-Lin , please set the ip to 0.0.0.0 instead of 9.91.12.117, as it should be default. Then I will merge the request. Thank you.

Sephiroth-Lin commented 9 years ago

@raduchilom, please merge the request. Thank you.

raduchilom commented 9 years ago

Done. Thank you.