Verizon / quiver

A reasonable library for modeling multi-graphs in Scala

http://verizon.github.io/quiver/

Apache License 2.0

200 stars 39 forks source link

Added tests to back the claims in the opened issues #23

Closed mgttlinger closed 7 years ago

mgttlinger commented 7 years ago

A few of the things only work once the head -> headOption fix is in the branch

timperrett commented 7 years ago

@mgttlinger CI fails :-(

mgttlinger commented 7 years ago

@timperrett Well that's the point. I added tests which showcase these errors in the path search.

timperrett commented 7 years ago

@mgttlinger ok you didn't reference the issue so that wasn't clear. You're talking about https://github.com/Verizon/quiver/issues/21 one assumes? We can discuss on the issue about a potential solution. Thanks for finding :-)

mgttlinger commented 7 years ago

21 and #22 actually

rossabaker commented 7 years ago

The cats port (#25) is a little more difficult than I envisioned, so I expect this and #24 can get through first, and then a subsequent Cats release after that.

mgttlinger commented 7 years ago

This should fix #21 and #22

rossabaker commented 7 years ago

Folded into release branch on #27.