search

Verizon / remotely

An elegant RPC system for reasonable people
http://verizon.github.io/remotely/
Apache License 2.0
306 stars 39 forks source link

Add some typelevel foo to Codecs! :-) #76

Closed jedesah closed 9 years ago

jedesah commented 9 years ago

No more fast and loose with Protocol definitions!!

timperrett commented 9 years ago

@jedesah morning. Could you shed a little more light on this? Cheers.

@stew you might want to look at this also.

stew commented 9 years ago

@timperrett I think I can. what it does is makes the Protocol parameterized on the types for which it has codecs, then it makes sure that when you try to specify a remote method, it must be able to find evidence that a codec exists for all the parameter types and the return type of the method you are sepcifying

jedesah commented 9 years ago

@stew Glad you were able to figure that out! Hopefully that means my implementation was easy to understand :-)

I replied by email this morning, but for some reason it never showed up...

jedesah commented 9 years ago

Sorry. I guess my description is a little cryptic. :-)

This change makes it so one cannot declare a function over types not included in the codecs of a protocol.

We briefly talked about this on Friday and since I was blocked on the other PR, I figured I would try my hand at it and it was easier than I expected! On May 6, 2015 8:30 AM, "Timothy Perrett" notifications@github.com wrote:

@jedesah https://github.com/jedesah morning. Could you shed a little more light on this? Cheers

— Reply to this email directly or view it on GitHub https://github.com/oncue/remotely/pull/76#issuecomment-99514780.