search

VermiIIi0n / fuckBookWalker

Download books from bookwalker.jp/bookwalker.com.tw
MIT License
18 stars 1 forks source link

Can I use it for Bookwalker.com.tw? #2

Closed gigihubb closed 4 months ago

gigihubb commented 7 months ago

Can I use it for Bookwalker.com.tw?

Thank you.

VermiIIi0n commented 7 months ago

I'm afraid not, but I will try to add this feature soon.😊

gigihubb commented 7 months ago

I'm afraid not, but I will try to add this feature soon.😊

Great, thank you!

VermiIIi0n commented 6 months ago

Hi, I've added experimental support for .com.tw and tested with some of my books.

There are a few incompletely tested things:

Anyway please try it out and your feedback will be appreciated!

Kifany commented 6 months ago

Hello, Bookwalker TW needs UTF-8 encoding to download books in Chinese name otherwise it will occurs an encode error. I added an encoding command to solve the problem , located at \bookphucker\tw.py line 127-129

    meta_path.write_text(json.dumps(
        {"title": title, "authors": authors},
        ensure_ascii=False, indent=2), encoding = "utf-8")

Download some recently published books successfully. Thank you so much.

VermiIIi0n commented 6 months ago

Hello, Bookwalker TW needs UTF-8 encoding to download books in Chinese name otherwise it will occurs an encode error. I added an encoding command to solve the problem , located at \bookphucker\tw.py line 127-129

    meta_path.write_text(json.dumps(
        {"title": title, "authors": authors},
        ensure_ascii=False, indent=2), encoding = "utf-8")

Download some recently published books successfully. Thank you so much.

Ah yes, thank you! I didn't test it on Windows and all of my systems use UTF-8 by default so this bug escaped my eyes. I will fix it later.