VermontDepartmentOfHealth / covid-bot

A knowledge base & automated chatbot from the Vermont Department of Health with info for the COVID-19 response
https://vermontdepartmentofhealth.github.io/covid-bot/
MIT License
3 stars 2 forks source link

Restore test refactor #47

Closed jmathias3 closed 4 years ago

jmathias3 commented 4 years ago

Main issue that this update solves is that the kb is not able to add and delete follow up prompts that point to the same question in the same update. Deleting and then Adding is the process we need to use to change existing follow up prompts. In order to make changes to existing follow up prompts, we have to identify when they are occurring, process the delete step in one update and then process the addition of the new version in a second update.

This update also includes extra formatting and updates to the Kb api readme

KyleMit commented 4 years ago

Did you intend to delete pollForOperationComplete from the latest commit? It looks like it's still in use

Doesn't show up on the PR deltas because it was added in this branch

jmathias3 commented 4 years ago

I can't reply to your pollForOperationComplete comment for some reason, so adding a new one. I did intend to delete it. I moved it to the Operations object and never deleted the original implementation. I think all of the references point to the version on operations.